[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm closed this revision. arsenm added a comment. c9d65a48af1d7bbfed7e785613cc9d9acf71821b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862 ___ cfe-commits mailing list

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm added a comment. In D76862#1953013 , @yaxunl wrote: > Are there any other clang options affecting flushing denormals? If so, are > they working properly after this change? Do we need to have tests for them? > Thanks. I already ensured these are

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

yaxunl added a comment. Are there any other clang options affecting flushing denormals? If so, are they working properly after this change? Do we need to have tests for them? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: kerbowa, tpr, nhaehnle, wdng, jvesely. Apparently HIPToolChain does not subclass from AMDGPUToolChain, so this was not applying the new denormal attributes. I'm not sure why this doesn't subclass.