[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 added a comment. In D77039#1967224 , @MyDeveloperDay wrote: > what is changing in clang/docs/ClangFormatStyleOptions.rst? if nothing then > remove from the diff there's an indentation issue, this changes the example of the doc from: -

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

MyDeveloperDay added a comment. what is changing in clang/docs/ClangFormatStyleOptions.rst? if nothing then remove from the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

This revision was automatically updated to reflect the committed changes. Closed by commit rG28ecd7f0b086: [clang-format] Dont break multi block parameters on… (authored by ghvg1313, committed by jinlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 added a comment. @jolesiak I don't yet have the commit access, do you mind help merging this diff? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 updated this revision to Diff 254015. ghvg1313 added a comment. reset diff's base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 updated this revision to Diff 254014. ghvg1313 added a comment. - Fix documentation formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

jolesiak accepted this revision. jolesiak added a comment. This revision is now accepted and ready to land. Makes sense, thanks for patching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 created this revision. ghvg1313 added reviewers: jolesiak, benhamilton. Herald added a project: clang. Herald added a subscriber: cfe-commits. While the original diff makes a lot of sense, and multiple inline block parameter/trailing paramemter after