dnsampaio accepted this revision.
dnsampaio added a comment.
This revision is now accepted and ready to land.
LGTM, not forgetting to remove the exit comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77074/new/
https://reviews.llvm.org/D77074
___
dnsampaio added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492
+ return Builder.CreateConstrainedFPCall(
+ F,
+ {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)),
Ops[0]});
+} else {
+ Function *F = CGM.getIntrins
kpn marked an inline comment as done.
kpn added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492
+ return Builder.CreateConstrainedFPCall(
+ F,
+ {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)),
Ops[0]});
+} else {
+
dnsampaio added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492
+ return Builder.CreateConstrainedFPCall(
+ F,
+ {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)),
Ops[0]});
+} else {
+ Function *F = CGM.getIntrins
dnsampaio added inline comments.
Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:288
+
+// XXX FIXME do we need to check for both w and x registers?
+// COMMON-LABEL: test_vceq_f64
kpn wrote:
> Anyone? I'm not an ARM expert.
The is variants o
kpn marked 3 inline comments as done.
kpn added a comment.
Note that the AArch64 backend isn't ready for some of these changes. That's why
the test is marked XFAIL.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5706
+Function *F;
+//exit(2); // XXX
+if (Builder.getIs
