[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

2020-04-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff abandoned this revision. sepavloff added a comment. Thank you, Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77520/new/ https://reviews.llvm.org/D77520 ___ cfe-commits mailing list

[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

2020-04-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. I don't think we can do this because GCC 5.1 won't support it. To confirm, that's still the minimum supported version:

[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

2020-04-05 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rjmccall, rnk, arsenm. Herald added a subscriber: wdng. Herald added a project: clang. If an option specified in LangOptions.def is of enum type, its default value should be a member of that enum, so scope qualifier may always be added