This revision was automatically updated to reflect the committed changes.
Closed by commit rGa010ef8bd88f: Add map-type check for target and target data
directive, by Chi Chun Chen (authored by cchen, committed by ABataev).
Changed prior to commit:
https://reviews.llvm.org/D77581?vs=255497&id=2
ABataev added a comment.
Sure, will do it later
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77581/new/
https://reviews.llvm.org/D77581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
cchen added a comment.
@ABataev , can you land it for me when you have time? thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77581/new/
https://reviews.llvm.org/D77581
___
cfe-commits mailing list
cchen updated this revision to Diff 255497.
cchen added a comment.
Reuse existing function for target/target data check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77581/new/
https://reviews.llvm.org/D77581
Files:
clang/lib/Sema/SemaOpenMP.cpp
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77581/new/
https://reviews.llvm.org/D77581
__
cchen marked an inline comment as done.
cchen added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038
+ // target, target data
+ // OpenMP 5.0 [2.12.2, Restrictions, p. 163]
+ // OpenMP 5.0 [2.12.5, Restrictions, p. 174]
+ // A map-type in
ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038
+ // target, target data
+ // OpenMP 5.0 [2.12.2, Restrictions, p. 163]
+ // OpenMP 5.0 [2.12.5, Restrictions, p. 174]
+ // A map-type in a map clause must be to, from, tofrom
cchen updated this revision to Diff 255481.
cchen added a comment.
Do not use lint on test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77581/new/
https://reviews.llvm.org/D77581
Files:
clang/lib/Sema/SemaOpenMP.cpp
clang/test/OpenMP/target_d
cchen created this revision.
cchen added a reviewer: ABataev.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77581
Files:
clang/lib/Sema/SemaOpenMP.cpp
clang/test/OpenM