[PATCH] D77581: Add map-type check for target and target data directive

2020-04-07 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa010ef8bd88f: Add map-type check for target and target data directive, by Chi Chun Chen (authored by cchen, committed by ABataev). Changed prior to commit: https://reviews.llvm.org/D77581?vs=255497&id=2

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Sure, will do it later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. @ABataev , can you land it for me when you have time? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 ___ cfe-commits mailing list

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 255497. cchen added a comment. Reuse existing function for target/target data check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 __

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038 + // target, target data + // OpenMP 5.0 [2.12.2, Restrictions, p. 163] + // OpenMP 5.0 [2.12.5, Restrictions, p. 174] + // A map-type in

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038 + // target, target data + // OpenMP 5.0 [2.12.2, Restrictions, p. 163] + // OpenMP 5.0 [2.12.5, Restrictions, p. 174] + // A map-type in a map clause must be to, from, tofrom

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 255481. cchen added a comment. Do not use lint on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_d

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen created this revision. cchen added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenM