[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan added a comment. In D77592#2002148 , @rjmccall wrote: > Okay. The plan sounds good to me. So you want to roll out this enum in this > patch, but not really use it for much until the follow-up? That was the plan, but I can also add include

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. Okay. The plan sounds good to me. So you want to roll out this enum in this patch, but not really use it for much until the follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan updated this revision to Diff 259602. leonardchan added a comment. Updated to reflect the changes in D72959 which make the vtable 4-byte aligned under the `Relative` layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan added a comment. > Okay, sure, if there are already offsets in bytes already in the AST-level > layout, I agree that we should be able to compute all of the byte offsets at > that level. > > How are you planning to handle alignments here? Currently alignment doesn't > affect the

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. In D77592#1987677 , @leonardchan wrote: > In D77592#1985740 , @rjmccall wrote: > > > I'm not sure if the AST-level v-table layout abstraction really cares about > > these differences. I

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan marked an inline comment as done. leonardchan added a comment. In D77592#1985740 , @rjmccall wrote: > I'm not sure if the AST-level v-table layout abstraction really cares about > these differences. I don't think it vends byte offsets into

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. I'm not sure if the AST-level v-table layout abstraction really cares about these differences. I don't think it vends byte offsets into the v-table, just slot indices (i.e. word offsets). Comment at: clang/include/clang/AST/VTableBuilder.h:380 +

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan updated this revision to Diff 257786. leonardchan retitled this revision from "[NFC}[CodeGen] Make VTable initialization a method of CGCXXABI" to "[NFC][CodeGen] Add enum for selecting the layout of components in the vtable". leonardchan edited the summary of this revision.