[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

2020-04-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D77611#1968236 , @nickdesaulniers wrote: > In D77611#1968227 , @dblaikie wrote: > > > Looks like GCC warns on everything but the last unused expression (the last > > one being the

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

2020-04-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D77611#1968227 , @dblaikie wrote: > Looks like GCC warns on everything but the last unused expression (the last > one being the return statement) - only warning on that last one if it's > ultimately unused by the

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

2020-04-07 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Looks like GCC warns on everything but the last unused expression (the last one being the return statement) - only warning on that last one if it's ultimately unused by the statement expression function call, as it were (& is annotated warn_unused_result). Basically,

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

2020-04-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 255823. nickdesaulniers added a comment. - tighten up condition, eagerly emit diag, test with kernel before pushing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77611/new/