[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

This revision was automatically updated to reflect the committed changes. Closed by commit rG792b10978dfd: [Driver][X86] Add -mpad-max-prefix-size (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:2190 HelpText<"Specify the boundary's size to align branches">; -def malign_branch_prefix_size_EQ : Joined<["-"],

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan updated this revision to Diff 256164. skan added a comment. Remove the limit "max padding prefix size <=5" since MC doesn't have this limit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 Files:

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan added a comment. In D77628#1969856 , @MaskRay wrote: > This looks like it requires more thorough discussions, doesn't it? We will > also need discussions with the binutils side. We requested a GCC compiler > driver option long ago but we do not

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

LuoYuanke added a comment. > This looks like it requires more thorough discussions, doesn't it? We will > also need discussions with the binutils side. We requested a GCC compiler > driver option long ago but we do not reach a consensus >

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. > It has similar (but slightly different) effect as GAS's option > -malign-branch-prefix-size, e.g. -mpad-max-prefix-size can also elminate NOPs > emitted by align directive, so

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan updated this revision to Diff 255953. skan added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 Files: clang/include/clang/Driver/Options.td

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan added a comment. The remote build failed due to a bug of Pre-merge checks, which tried to apply a landed patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan updated this revision to Diff 255583. skan added a comment. format the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 Files: clang/include/clang/Driver/Options.td

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. skan edited the summary of this revision. The option `-mpad-max-prefix-size` performs some checking and delegate to MC option `-x86-pad-max-prefix-size`. This option is designed for eliminate NOPs