[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

2020-04-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG48d851a92e98: [clangd] Update TUStatus test to handle async PreambleThread (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77669/new/

[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

2020-04-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 256875. kadircet marked 6 inline comments as done. kadircet added a comment. - Record actions for each thread separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77669/new/

[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

2020-04-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. going with separately recording each thread. that way we can also test building of diagnostics. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:849 + auto Opts = ClangdServer::optsForTest(); + Opts.AsyncThreadsCount = 0; +

[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Now having read it, I'm slightly nervous we're not catching all the interleavings. An alternate approach if this is too messy would be just to capture the two streams of enums