[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG789215dc0db1: [ASTImporter] Add support for importing fixed point literals (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

martong accepted this revision. martong added a comment. Looks good! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 ___ cfe-commits mailing list cfe-co

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers added a comment. Do these changes look ok to land? https://reviews.llvm.org/D57226 is pushed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 __

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256339. vabridgers added a comment. Incorporate Gabor's suggestion for improving test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 Files: clang/include

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers marked an inline comment as done. vabridgers added a comment. Ahhh yes, I see. I can get this done while we're waiting on https://reviews.llvm.org/D57226 to land. Thanks Gabor!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ h

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Hi Vince, this looks good to me! On the other hand I was pondering on @balazske's comment, this one: > Or use the new flag added to every item in DefaultTestValuesForRunOptions, > specially

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256234. vabridgers added a comment. Address comment from @balazske Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 Files: clang/include/clang/ASTMatchers/ASTMatche

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

balazske added inline comments. Comment at: clang/include/clang/AST/Expr.h:1494 SourceLocation l, unsigned Scale); - // Store the int as is without any bit shifting. This line removal is not needed and can cause disturbances, it is better

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256131. vabridgers added a comment. Addressed comments from @balazske. Thanks for the tips and useful starting point from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llv

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256133. vabridgers added a comment. Remove extraneous code :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 Files: clang/include/clang/AST/Expr.h clang/include

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers added a comment. @balazske, Thank you for the comments. I'll address and repost the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 ___ cfe-c

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:1000 + hasDescendant(fixedPointLiteral(); +} + See test `ImportFloatinglLiteralExpr` for a better implementation of this test. The new test could be inc

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers created this revision. vabridgers added reviewers: martong, leonardchan, ebevhan. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. vabridgers added a comment. Landing this chan

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers added a comment. Landing this change depends on https://reviews.llvm.org/D57226 to be pushed. Please review for now, and I'll be sure to push this only after https://reviews.llvm.org/D57226 is pushed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https: