andwar added a comment.
The buildbot failures are unrelated to this patch, and locally `make check-all`
worked fine. I'll submit this patch as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77735/new/
https://reviews.llvm.org/D77735
sdesmalen accepted this revision.
sdesmalen added a comment.
LGTM! Cheers @andwar
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77735/new/
https://reviews.llvm.org/D77735
___
cfe-commits mailing list
andwar added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7458
+llvm_unreachable("Invalid SVETypeFlag!");
+
+ case SVETypeFlags::EltTyInt8:
SjoerdMeijer wrote:
> nit: no need for the newlines here and also below?
IMHO this improves
sdesmalen added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7451
+ }
+ llvm_unreachable("Unknown MemEltType");
+}
SjoerdMeijer wrote:
> nit: to be consistent, do this in the default clause?
Doing that would lead to
warning: default label
sdesmalen added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7601
+ llvm::Type *SrcDataTy = getSVEType(TypeFlags);
+ llvm::Type *OverloadedTy = llvm::VectorType::get(
+ SVEBuiltinMemEltTy(TypeFlags), SrcDataTy->getVectorElementCount());
SjoerdMeijer accepted this revision.
SjoerdMeijer added a reviewer: efriedma.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
This is a big patch, but looks reasonable to me.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7451
+ }
+
