[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e8af0ecbe7: [Clang] Expose RequiresNullTerminator in FileManager. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D2?vs=256722=257852#toc Repository: rG LLVM Github

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/unittests/Support/MemoryBufferTest.cpp:396 + + auto MBOrError = MemoryBuffer::getOpenFile(FD, TestPath, -1, false, true); +

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Bigcheese updated this revision to Diff 256722. Bigcheese added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

dexonsmith added a comment. In D2#1973250 , @Bigcheese wrote: > Not really. It's a static function in MemoryBuffer.cpp, and the > `MemoryBuffer` class doesn't have a `Kind` member so we can't check for > `MemoryBufferMMapFile`. Ah, but there's a

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Bigcheese added a comment. Not really. It's a static function in MemoryBuffer.cpp, and the `MemoryBuffer` class doesn't have a `Kind` member so we can't check for `MemoryBufferMMapFile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

dexonsmith added a comment. Code change LGTM. Is there a way to add a `MemoryBuffer` unit test for the change to `shouldUseMmap`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Bigcheese created this revision. Bigcheese added reviewers: dexonsmith, vsapsai, rdhindsa. Bigcheese added a project: clang. Herald added a subscriber: hiraditya. This is needed to fix the reason 0a2be46cfdb698fe (Modules: Invalidate out-of-date PCMs as they're discovered) and 5b44a4b07fc1d