[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

This revision was automatically updated to reflect the committed changes. Closed by commit rG596b63ad4019: [clangd] Rebuild dependent files when a header is saved. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77847?vs=256756&id=257097#toc Repository: rG LLVM Gi

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

kadircet added a comment. In D77847#1976077 , @sammccall wrote: > OK, I misunderstood what we're testing, please tell me if I got it right this > time :-) > > Plausible bad behavior: we send a no-op change to a relatively inactive file. > TUScheduler bui

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

sammccall added a comment. In D77847#1976020 , @kadircet wrote: > Thanks, LGTM! > > In D77847#1975940 , @sammccall wrote: > > > In D77847#1974126 , @kadircet > > wrote: > >

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! In D77847#1975940 , @sammccall wrote: > In D77847#1974126 , @kadircet wrote: > > > should we

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

sammccall updated this revision to Diff 256756. sammccall marked an inline comment as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77847/new/ https://reviews.llvm.org/D77847 Files: clang-

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

sammccall marked 3 inline comments as done. sammccall added a comment. In D77847#1974126 , @kadircet wrote: > should we also have a unittest for checking ast caching works as expected? TUSchedulerTests has `NoopOnEmptyChanges` which I think tests exactly

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

kadircet added a comment. should we also have a unittest for checking ast caching works as expected? ClangdServer::getUsedBytesPerFile should allow us to do that. We can set cache size to one, send 3 updates in respective order to foo, bar and baz, we record usedbytesperfile. Then we perform ad

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Caveats: - only works when the header is changed in the editor and the editor provides the notificat