[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

wenlei added a comment. In D77925#2236519 , @tejohnson wrote: > In D77925#2229484 , @mehdi_amini > wrote: > >> Overall that would likely work for XLA. Something I'd like to mention though >> in response to: >>

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

tejohnson added a comment. In D77925#2229484 , @mehdi_amini wrote: > Overall that would likely work for XLA. Something I'd like to mention though > in response to: > >> The veclib type is also tied to the accepted values for -fveclib, which is a >> list

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

mehdi_amini added a comment. Overall that would likely work for XLA. Something I'd like to mention though in response to: > The veclib type is also tied to the accepted values for -fveclib, which is a > list of supported lib, `-fveclib` is a Clang thing, it shouldn't limit what LLVM does. Of

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

wenlei added a comment. In D77925#2220177 , @wenlei wrote: > In D77925#2220169 , @mehdi_amini > wrote: > >> I rather have a non closed list of veclib: if you just have a map keyed by >> string instead of an enum

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

wenlei added a comment. In D77925#2220169 , @mehdi_amini wrote: > I rather have a non closed list of veclib: if you just have a map keyed by > string instead of an enum it should just work out? The veclib type is also tied to the accepted values for

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

mehdi_amini added a comment. I rather have a non closed list of veclib: if you just have a map keyed by string instead of an enum it should just work out? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77925/new/ https://reviews.llvm.org/D77925

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

wenlei added a comment. In D77925#2016326 , @tejohnson wrote: > In D77925#2016299 , @wenlei wrote: > >> @mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under >> the impression that a test case

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

tejohnson added a comment. In D77925#2016299 , @wenlei wrote: > @mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the > impression that a test case demonstrating the 3rd party usage will be added > very soon after this revert,

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

wenlei added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. @mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the impression that a test case demonstrating the 3rd party usage will be added very soon after this revert, then we can tweak

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

This revision was automatically updated to reflect the committed changes. Closed by commit rGed03d9485eb5: Revert [TLI] Per-function fveclib for math library used for vectorization (authored by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77925/new/ https://reviews.llvm.org/D77925

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

mehdi_amini created this revision. mehdi_amini added a reviewer: tejohnson. Herald added subscribers: cfe-commits, haicheng, hiraditya, eraman. Herald added a project: clang. mehdi_amini added a reviewer: wenlei. tejohnson accepted this revision. tejohnson added a comment. This revision is now