kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, i think this LG.
Comment at:
clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1697-1698
+ )cpp");
+ TU.HeaderFilename = "Foo.h";
+ auto Symbols =
sammccall added a comment.
OK, time to revive this patch, sorry for letting it die.
Meanwhile, the lexer change has landed separately, so that's gone.
I've removed the gratuitous clangd indexing changes in order to focus this on
the serialization hacks.
Comment at:
sammccall updated this revision to Diff 540985.
sammccall marked an inline comment as done.
sammccall added a comment.
oops
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78038/new/
https://reviews.llvm.org/D78038
Files:
sammccall updated this revision to Diff 540981.
sammccall added a comment.
rebase and narrow scope
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78038/new/
https://reviews.llvm.org/D78038
Files:
nridge added a comment.
Also adding links to the open issues this fixes:
- https://github.com/clangd/clangd/issues/333
- https://github.com/clangd/clangd/issues/337
Note the second issue is not specific to include insertion; it's a false
positive diagnostic, which I think makes it a more
nridge added reviewers: hokein, kadircet, VitaNuo.
nridge added a comment.
Let's try adding some reviewers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78038/new/
https://reviews.llvm.org/D78038
___
voertler added a comment.
We stumbled upon this issue too. What is needed to pull in this patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78038/new/
https://reviews.llvm.org/D78038
___
cfe-commits
nridge added a comment.
Herald added projects: LLVM, clang-tools-extra, All.
Herald added a subscriber: llvm-commits.
@sammccall should we get this patch landed? The issue of #ifndef-guarded header
files that include each other recursively is still tripping up some users.
Repository:
rG LLVM
kadircet added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2749
+// most useful answer is "yes, this file has a header guard".
+if (!ConditionalStack.empty())
+ MIOpt.ExitTopLevelConditional();
I think we should put this behind a PPOpt to
sammccall created this revision.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
This should probably be untangled into 3 separate patches, but
looking for feedback first on whether we want to do this at all.
a) store
10 matches
Mail list logo
