[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

melver added a comment. This seems to be causing problems for the Linux kernel with ASan instrumentation enabled: https://lkml.kernel.org/r/20200518180513.ga114...@google.com Still investigating if it's the kernel, KASAN, or Clang that's doing something wrong. Any pointers welcome. Many

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

nickdesaulniers added a comment. The same failing assertion is tripping up Linaro's TCWG Linux kernel builds: - https://ci.linaro.org/job/tcwg_kernel-bisect-llvm-master-arm-mainline-allmodconfig/33/artifact/artifacts/build-2dd17ff08165e6118e70f00e22b2c36d2d4e0a9a/03-build_linux/console.log -

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

george.burgess.iv added a comment. Thanks for the report! Looking now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78162/new/ https://reviews.llvm.org/D78162 ___ cfe-commits mailing list

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

mstorsjo added a comment. This triggers failed asserts: $ cat dcpdecrypt.cpp extern "C" __inline__ __attribute__((__gnu_inline__)) void * memcpy(void *, const void *, unsigned) {} void *memcpy(void *, const void *, unsigned); void a() { memcpy; } $ clang++ -c dcpdecrypt.cpp -target

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dd17ff08165: [CodeGen] only add nobuiltin to inline builtins if well emit them (authored by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

george.burgess.iv added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78162/new/ https://reviews.llvm.org/D78162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78162/new/ https://reviews.llvm.org/D78162

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

george.burgess.iv created this revision. george.burgess.iv added reviewers: efriedma, serge-sans-paille. george.burgess.iv added a project: clang. Herald added a subscriber: cfe-commits. This suboptimality was encountered in Linux (see some discussion on D71082 ,