[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

carlos4242 added a comment. Herald added a subscriber: dexonsmith. Can I just add a +1 on something like this. My swift compiler build just broke at runtime because of this. Would it be possible to change the default so it reads the address space from the target data layout so it's all automati

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

dylanmckay added a comment. Note to the readers: A recent-ish llvm-dev discussion around this patch can be found in here whrein a consensus is found on the way forward on this patch. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson updated this revision to Diff 279861. arichardson added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78491/new/ https://reviews.llvm.org/D78491 Files: clang/lib/CodeGen/CGOpenMPRuntime.h llvm/include/llvm/Analys

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson added a comment. In D78491#2040424 , @dylanmckay wrote: > I really like the idea behind this patch, but I suspect there is a better way > to go about it. > > The only drawbacks to upstreaming this patch as-is is the idea that because > it is

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

dylanmckay added a comment. Herald added a project: LLVM. I really like the idea behind this patch, but I suspect there is a better way to go about it. The only drawbacks to upstreaming this patch as-is is the idea that because it is implemented as a compiler define directive, it effectively sp

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

dylanmckay added a comment. > should help targets such as AVR than use a non-zero program address space. It definitely will - we have the exact same problems in terms of every call to `getUnqual` on a function pointer becomes a ISel error. > I think making such bugs a compilation failure should

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

lebedev.ri added subscribers: llvm-commits, lebedev.ri. lebedev.ri added a comment. This should really be reviewed on llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78491/new/ https://reviews.llvm.org/D78491

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson marked an inline comment as done. arichardson added a comment. In D78491#1992618 , @aykevl wrote: > I can't give an LGTM but at least from my perspective I very much welcome > this change. I am still hitting problems with non-zero address spac

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

aykevl added a comment. I can't give an LGTM but at least from my perspective I very much welcome this change. I am still hitting problems with non-zero address spaces on AVR. One nit in an inline comment. Do you plan on eventually removing `LLVM_NO_IMPLICIT_ADDRESS_SPACE` when the transition

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson created this revision. arichardson added reviewers: aykevl, dylanmckay, arsenm, bjope, theraven, jrtc27. Herald added subscribers: cfe-commits, hiraditya, mgorny, wdng. Herald added a reviewer: ctetreau. Herald added a project: clang. APIs such as PointerType::getUnqual/Type::getPoint