[PATCH] D78938: Make LLVM build in C++20 mode

bmahjour added inline comments. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:40 /// Static polymorphism: delegate implementation (via isEqualTo) to the /// derived class. + bool operator==(const DGEdge ) const { jfb wrote: > That comment, so

[PATCH] D78938: Make LLVM build in C++20 mode

RKSimon added a comment. In D78938#2460360 , @nlopes wrote: > Just saw that you fixed it already. Thank you! 'Avoided' might be a better term than 'fixed' tbh - I didn't delve much into why it was breaking, or what effect it has on C++20 work.

[PATCH] D78938: Make LLVM build in C++20 mode

nlopes added a comment. In D78938#2459973 , @RKSimon wrote: > @BRevzin @nlopes This is causing MSVC build failure please can you take a > look? > > E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): > note: see declaration of

[PATCH] D78938: Make LLVM build in C++20 mode

RKSimon added a comment. @BRevzin @nlopes This is causing MSVC build failure please can you take a look? E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): note: see declaration of 'std::reverse_iterator' E:\llvm\llvm-project\llvm\lib\DWARFLinker\DWARFLinker.cpp(383):

[PATCH] D78938: Make LLVM build in C++20 mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92310454bf0f: Make LLVM build in C++20 mode (authored by BRevzin, committed by nlopes). Changed prior to commit:

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added a comment. In D78938#2450915 , @nlopes wrote: > Thanks @lebedev.ri for the pointer! > I started working on exactly the same thing as I was trying to link a C++20 > project with LLVM. > @BRevzin is there anything missing in this patch? Do

[PATCH] D78938: Make LLVM build in C++20 mode

MaskRay added a comment. @BRevzin Please share your name and email if you want someone to commit it for you https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/

[PATCH] D78938: Make LLVM build in C++20 mode

nlopes added a comment. Thanks @lebedev.ri for the pointer! I started working on exactly the same thing as I was trying to link a C++20 project with LLVM. @BRevzin is there anything missing in this patch? Do you have commit access or do you need help to land this? Repository: rG LLVM Github

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) dblaikie wrote: > Quuxplusone wrote: > > BRevzin wrote: > > > dblaikie wrote: > > > > BRevzin wrote: >

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171 - -inline bool operator!=(const DWARFExpression::iterator , - const DWARFExpression::iterator ) { - return !(LHS == RHS); -} lebedev.ri

[PATCH] D78938: Make LLVM build in C++20 mode

lebedev.ri added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171 - -inline bool operator!=(const DWARFExpression::iterator , - const DWARFExpression::iterator ) { - return !(LHS == RHS); -} BRevzin

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) dblaikie wrote: > BRevzin wrote: > > dblaikie wrote: > > > What tripped over/required this SFINAE? > >

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) Quuxplusone wrote: > dblaikie wrote: > > BRevzin wrote: > > > dblaikie wrote: > > > > What tripped

[PATCH] D78938: Make LLVM build in C++20 mode

Quuxplusone added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) dblaikie wrote: > BRevzin wrote: > > dblaikie wrote: > > > What tripped over/required this SFINAE? >

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) BRevzin wrote: > dblaikie wrote: > > What tripped over/required this SFINAE? > There's somewhere which

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171 - -inline bool operator!=(const DWARFExpression::iterator , - const DWARFExpression::iterator ) { - return !(LHS == RHS); -} dblaikie

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added a comment. In D78938#2262713 , @jhenderson wrote: > In D78938#2261411 , @jfb wrote: > >> On C++20 mode rotting: it won't if someone sets up a bot. If it rots, then >> it's easier to un-rot with

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added a comment. > @BRevzin, you should a) mention the u8/const char* issue in the description > too, and also what compiler you used to build this with. I fully expect at > this stage that there are some C++20 compilers that might have slightly > different interpretations of things

[PATCH] D78938: Make LLVM build in C++20 mode

jhenderson added a comment. In D78938#2261411 , @jfb wrote: > On C++20 mode rotting: it won't if someone sets up a bot. If it rots, then > it's easier to un-rot with Barry's patch. I assume this would be a private bot? It can't be a public bot, since