[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fa13a3dac1e: [clang][OpenMP] Fix getNDSWDS for aarch64. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli updated this revision to Diff 261610. fpetrogalli added a comment. I have added (indirect) testing of the values of NDS and WDS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 Files: clang/li

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli updated this revision to Diff 261611. fpetrogalli added a comment. Removed single use variable definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 Files: clang/lib/CodeGen/CGOpenMPRunt

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli added a comment. In D78969#2012591 , @jdoerfert wrote: > Is the NDS and WDS number never visible in the IR, e.g., as part of the name? Hang on, thanks for asking the question, maybe I can work something out here! :) They won't be visible in

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

jdoerfert added a comment. Is the NDS and WDS number never visible in the IR, e.g., as part of the name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 ___ cfe

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli added a comment. Hello reviewers, I know this is not how the fix should be tested (`fprintf` in debug builds...). This function would benefit of some unitests in the `unittests` folder of clang, but I don't have a way to export it there as it is private to this module. I would lik

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli created this revision. fpetrogalli added a reviewer: ABataev. Herald added subscribers: cfe-commits, danielkiss, guansong, kristof.beyls, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. fpetrogalli added a comment. Hello reviewers, I know this is not how th