[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c9230dad169: Reland [libclang] Install both libclang.a and libclang.so when… (authored by zhuhan0, committed by smeenai). Changed prior to commit: https://reviews.llvm.org/D79059?vs=262506&id=262530#to

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Committed. Please let me know of any buildbot failure emails you receive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___ cfe-commi

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 added a comment. @smeenai Yes please. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Do you need me to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 262506. zhuhan0 added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 Files: clang/cmake/modules/AddClang.cmake Index: clang/cmake/modules

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry for the delayed review here. I'm not the biggest fan of this cos it's encoding knowledge of `llvm_add_library`'s internal behavior (that it creates a `*_static` target if both STATIC

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 261866. zhuhan0 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 Files: clang/cmake/modules/AddClang.cmake Index: clang/cmake/modules/AddClang

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 260818. zhuhan0 edited the summary of this revision. zhuhan0 added a comment. Spacing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 Files: clang/cmake/modules/AddC

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. zhuhan0 edited the summary of this revision. D78354 enabled installing PIC version of both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC is ON. Bu