[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

dblaikie added a subscriber: echristo. dblaikie added a comment. In D79147#2178104 , @russell.gallop wrote: > Hi, > > It looks like is causing one of the debuginfo-tests: > llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't >

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

russell.gallop added a comment. Hi, It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change. Please

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

This revision was automatically updated to reflect the committed changes. Closed by commit rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited) (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

akhuang updated this revision to Diff 276778. akhuang added a comment. fix one more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79147/new/ https://reviews.llvm.org/D79147 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Could you include some comparative data in the description/commit message demonstrating this generally ends up emitting all the same types for a clang build before/after (& explanations