This revision was automatically updated to reflect the committed changes.
Closed by commit rGd6936be2ef8c: [SveEmitter] Add builtins for svdup and
svindex (authored by sdesmalen).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79357/new/
https://reviews.llvm.org/D79357
___
cfe-commits mailing list
cfe-commi
sdesmalen updated this revision to Diff 263258.
sdesmalen added a comment.
- Use `llvm.aarch64.sve.dup.x` for `svdup_n_b`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79357/new/
https://reviews.llvm.org/D79357
Files:
clang/include/clang/Basic/arm_sve.td
clang/lib/CodeGen/CGBuiltin
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8047
+Value *PFalse = Constant::getNullValue(PTrue->getType());
+Value *Sel = Builder.CreateSelect(CmpNE, PTrue, PFalse);
+return EmitSVEPredicateCast(Sel, cast(Ty));
sdesmale
sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1050
def SVCOMPACT: SInst<"svcompact[_{d}]", "dPd", "ilUiUlfd",
MergeNone, "aarch64_sve_compact">;
-// SVDUP_LANE(to land in D78750)
efriedma added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1050
def SVCOMPACT: SInst<"svcompact[_{d}]", "dPd", "ilUiUlfd",
MergeNone, "aarch64_sve_compact">;
-// SVDUP_LANE(to land in D78750)
+def SVDUP_LANE : SInst<"svdup_lane[_{d}]",
sdesmalen created this revision.
sdesmalen added reviewers: efriedma, SjoerdMeijer, kmclaughlin.
Herald added subscribers: arphaman, tschuett.
sdesmalen added a parent revision: D79356: [CodeGen][SVE] Add patterns for
whole vector predicate select.
https://reviews.llvm.org/D79357
Files:
clang/