[PATCH] D79397: [clang] Fix an uint32_t overflow in large preamble.

2020-05-05 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4f8d9722b499: [clang] Fix an uint32_t overflow in large preamble. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79397/new/

[PATCH] D79397: [clang] Fix an uint32_t overflow in large preamble.

2020-05-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for tracking this down! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79397/new/ https://reviews.llvm.org/D79397

[PATCH] D79397: [clang] Fix an uint32_t overflow in large preamble.

2020-05-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. I was surprised to see the LocalOffset can exceed uint32_t, but it does happen and lead to crashes in one of our internal huge TU with a large preamble. with this patch, the crash is gone.