[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-fsetpos-argument-check.cpp:1 +// RUN: %check_clang_tidy %s bugprone-fsetpos-argument-check %t + This is a C, not a C++ file, the extension should show it. In

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

aaron.ballman added a comment. btw, if you're interested in exploring a static analyzer solution for this, here's a recent review of an analyzer feature that's in the same general problem space: https://reviews.llvm.org/D80018 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

aaron.ballman added a comment. In D79437#2052704 , @DerWaschbar wrote: > In D79437#2052109 , @aaron.ballman > wrote: > > > Have you considered writing a static analyzer check so you can do data and > > control

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar added a comment. In D79437#2052109 , @aaron.ballman wrote: > Thank you for working on this check, I think it's useful functionality. One > concern I have, though, is that it's not flow-sensitive and should probably > be implemented as a

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 265930. DerWaschbar marked 3 inline comments as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 Files:

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

aaron.ballman added a comment. Thank you for working on this check, I think it's useful functionality. One concern I have, though, is that it's not flow-sensitive and should probably be implemented as a clang static analyzer check instead of a clang-tidy check. For instance, consider these

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 264949. DerWaschbar added a comment. Rebased Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 262383. DerWaschbar marked 7 inline comments as done. DerWaschbar added a comment. - Removed unnecessary empty lines. - Added double back-ticks to highlight language constructs. - Indented code in documentation. Repository: rCTE Clang Tools Extra

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar added a comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org