[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-06 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a comment. Mind looking again? They did add one later on I think. It helped a lot since the exact settings and whitespace to trigger this are really finicky (though reproducible). You're right that it won't reproduce without it. Here's a run log of the failing test I added,

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-06 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I don't seem to be able to reproduce the original problem (either will your test case or the bad.h) It would be good if the PR had the exact .clang-format file being used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-05 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a project: clang-format. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, VelocityRa, sylvestre.ledru, sammccall, enyquist. JakeMerdichAMD added a comment. The failing case in this commit looks like the following after formatting (with alignconsecutiveassignments an

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-05 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. JakeMerdichAMD added a project: clang-format. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, VelocityRa, sylvestre.ledru, sammccall, enyquist. JakeMerdichAMD added a comment. Th