[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. Landed in d03838343f2199580 . Found another bug elsewhere while looking at this, will make a patch for that now.

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2123 +isLowercase(Name[0]) != isLowercase(RealPathName[0])) { + assert(Components.size() >= 3 && "should have drive, backslash, name"); +

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks reasonable to me, but Windows paths are scary.. Comment at: clang/lib/Lex/PPDirectives.cpp:2112 +// letter for absolute paths, but Name might start with either +//

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2118 +// given drive letter case as correct for the purpose of this warning. +SmallString<128> FixedDriveRealPath; +if

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

rnk added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2118 +// given drive letter case as correct for the purpose of this warning. +SmallString<128> FixedDriveRealPath; +if (llvm::sys::path::is_absolute(Name) && It seems like

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. See PR45812 for motivation. No explicit test since I couldn't figure out how to get the current disk drive in lower case into a form in lit where I could