Re: [PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-18 Thread Hans Wennborg via cfe-commits
+thakis who I think fell off the cc list On Thu, May 14, 2020 at 12:51 AM Abhinav Gaba via Phabricator wrote: > > abhinavgaba added inline comments. > > > > Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 > // RUN: touch %t.dir/foo.h > -// RUN: not %clang_cl

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-13 Thread Abhinav Gaba via Phabricator via cfe-commits
abhinavgaba added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-11 Thread Abhinav Gaba via Phabricator via cfe-commits
abhinavgaba added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-08 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG51d938bc9443: Fix bugs when an included file name is typo corrected. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-08 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79595/new/ https://reviews.llvm.org/D79595 ___ cfe-commits mailing list

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-07 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. D52774 fixed a bug with typo correction of includes, but didn't add a test. D65907 then broke recovery of typo correction of includes again, because it extracted the