This revision was automatically updated to reflect the committed changes.
Closed by commit rG866dc0978449: [clang-tidy] Better support for Override
function in RenamerClangTidy based… (authored by njames93).
Changed prior to commit:
https://reviews.llvm.org/D79674?vs=298616=299043#toc
njames93 updated this revision to Diff 298616.
njames93 added a comment.
Updated release notes to reflect change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79674/new/
https://reviews.llvm.org/D79674
Files:
alexfh added a comment.
Feel free to ping patches every week or so. It looks like in this case all the
reviewers were swamped with something else at the time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79674/new/
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thanks for the fix! IIUC, this is related to
https://bugs.llvm.org/show_bug.cgi?id=34879? Makes sense to specify this in the
patch description.
Repository:
rG LLVM Github
njames93 created this revision.
njames93 added reviewers: aaron.ballman, gribozavr2, alexfh.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a project: clang.
Methods that override virtual methods will now get renamed if the initial
virtual method has a name violation.
