[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-22 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon closed this revision. RKSimon added a comment. Committed at rGb30c16670e428d09a0854a8f418e46a3e705e4d1 (with a typo in the Differential Revision tag so phab didn't catch it) CHANGES SINCE LAST ACTION

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 ___ cfe-commits mailing

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-18 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 271713. erichkeane marked 9 inline comments as done. erichkeane added a comment. @AaronBallman's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2699 +RHSValue.getInt(), Result); + assert(LHSValue.getKind() == APValue::Float && "SHhuld be no other options"); + return

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-18 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon edited reviewers, added: efriedma; removed: eli.friedman. RKSimon added a comment. Any frontend people got any comments on this? I'm keen to see constexpr vector support added but know next to nothing about the frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-05-12 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added reviewers: rsmith, void. RKSimon added a comment. Adding some people who know more about this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 ___ cfe-commits mailing list

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-05-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: eli.friedman, RKSimon, aaron.ballman. These operations do member-wise versions of the all of the listed operations. This patch implements all of the binaryoperators for these types. Note that the test is required to use codegen as I