This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ee479a760e0: [RISCV] Fix passing two floating-point values
in complex separately by two GPRs… (authored by Jim).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Good catch, thanks for the fix! The logic was incorrectly written assuming
`isFloatingType` would return false for complex values which is of course
incorrect.
Comment at: clang/
luismarques added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10241-10242
// Pass floating point values via FPRs if possible.
- if (IsFixed && Ty->isFloatingType() && FLen >= Size && ArgFPRsLeft) {
+ if (IsFixed && Ty->isFloatingType() && !Ty->isComplexType
Jim created this revision.
Jim added reviewers: asb, luismarques, lenary.
Herald added subscribers: cfe-commits, evandro, apazos, sameer.abuasal, pzheng,
s.egerton, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult,
MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-che
