This revision was automatically updated to reflect the committed changes.
Closed by commit rGbd1c03d7b7c8: [OPENMP50]Codegen for inscan reductions in
worksharing directives. (authored by ABataev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
Thx for the explanation. LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79948/new/
https://reviews.llvm.org/D79948
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14900
}
-continue;
}
jdoerfert wrote:
> Why would we continue after this error?
The function, that uses VLAs, might be
jdoerfert added a comment.
Looks good, puzzled about the one changed mentioned below.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14900
}
-continue;
}
Why would we continue after this error?
Repository:
rG LLVM Github Monorepo
ABataev updated this revision to Diff 268242.
ABataev added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79948/new/
https://reviews.llvm.org/D79948
Files:
clang/include/clang/AST/OpenMPClause.h
ABataev updated this revision to Diff 267298.
ABataev added a comment.
Herald added a subscriber: sstefan1.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79948/new/
https://reviews.llvm.org/D79948
Files:
ABataev created this revision.
ABataev added a reviewer: jdoerfert.
Herald added subscribers: arphaman, guansong, yaxunl.
Herald added a project: clang.
Implemented codegen for reduction clauses with inscan modifiers in
worksharing constructs.
Emits the code for the directive with inscan
