[PATCH] D79967: Fix debug info for NoDebug attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG361e4f14e359: Fix debug info for NoDebug attr (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a comment. In D79967#2045196 , @vsk wrote: > @yaxunl thanks, this patch lgtm. > > @dblaikie I've kicked off a thread on cfe-dev about the topics you brought up > ("Design discussion re: DW_TAG_call_site support in clang") and cc'd you. Th

[PATCH] D79967: Fix debug info for NoDebug attr

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. @yaxunl thanks, this patch lgtm. @dblaikie I've kicked off a thread on cfe-dev about the topics you brought up ("Design discussion re: DW_TAG_call_site support in clang") and cc'd you. CHANGES SIN

[PATCH] D79967: Fix debug info for NoDebug attr

djtodoro added a comment. This seems reasonable, so this change looks good to me! @dblaikie Thanks for pointing out to the potential problems of the usage of the func decl !dbg in the purpose of call sites debug info. It is currently being stored into CU's retainedTypes field. > That's why DIS

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added subscribers: djtodoro, dexonsmith. dblaikie added a comment. In D79967#2041595 , @yaxunl wrote: > In D79967#2039153 , @dblaikie wrote: > > > Could you check the commit history for this feature and rop

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl updated this revision to Diff 264622. yaxunl marked 2 inline comments as done. yaxunl added a comment. Fix the tests and move the logic to CGDebugInfo::EmitFuncDeclForCallSite to make it clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/ https://reviews.llvm.org/D

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl marked 4 inline comments as done. yaxunl added a comment. In D79967#2039153 , @dblaikie wrote: > Could you check the commit history for this feature and rope in some folks > who added the function declaration work (it's for debug call sites) - mayb

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a subscriber: vsk. dblaikie added a comment. Could you check the commit history for this feature and rope in some folks who added the function declaration work (it's for debug call sites) - maybe @vsk is the right person, or knows who is, to check this is the right fix for it/doe

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl updated this revision to Diff 264148. yaxunl added a comment. add a test for nodebug attr. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/ https://reviews.llvm.org/D79967 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/nodebug-attr.c clang/test/CodeGen

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl added a comment. In D79967#2037675 , @dblaikie wrote: > I'm not quite following the test case - could you explain how it's testing > the situation? > > It might be better/easier to have a more intentional test - also, could you > check the commit

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a comment. I'm not quite following the test case - could you explain how it's testing the situation? It might be better/easier to have a more intentional test - also, could you check the commit history for this declaration-emitting functionality (CGDebugInfo::EmitFunctionDecl wh

[PATCH] D79967: Fix debug info for NoDebug attr

tra added a reviewer: dblaikie. tra added a subscriber: dblaikie. tra added a comment. LGTM. Added @dblaikie as reviewer for debug info expertise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/ https://reviews.llvm.org/D79967 ___

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a subscriber: aprantl. NoDebug attr does not totally eliminate debug info about a function when inlining is enabled. This is inconsistent with when inlining is disabled. This patch fixes that. https://reviews.llvm