[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen abandoned this revision. cchen added a comment. Created a new patch with the support for stride: https://reviews.llvm.org/D84192. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2124108 , @cchen wrote: > @ABataev , I'm considering emitting an extra dimension for a non-contiguous > descriptor to support stride in this patch (stride = 1 in array section is > just a special case for computing

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev , I'm considering emitting an extra dimension for a non-contiguous descriptor to support stride in this patch (stride = 1 in array section is just a special case for computing stride, however, the formula computing stride do not change). Do you think I should do

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

kkwli0 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +/// non-contiguous list items in

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a subscriber: kkwli0. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273778. cchen added a comment. Rebase and resolve conflictions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273747. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16665 // Record the component - we don't have any declaration associated. -Components.emplace_back(OASE, nullptr); +Components.emplace_back(OASE, nullptr, false); return RelevantExpr ||

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273529. cchen added a comment. Pass Info directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10334-10335 +MCHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + Info.Dims, Info.Offsets, Info.Counts, + Info.Strides);

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273517. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else cchen wrote: > ABataev wrote: > > Better to use

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else ABataev wrote:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy , - CGOpenMPRuntime::TargetDataInfo ) { +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy , - CGOpenMPRuntime::TargetDataInfo ) { + MappableExprsHandler::MapDimArrayTy , +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273484. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7849-7851 +if ( != &*Components.begin()) { + ElementType = ElementType->getPointeeOrArrayElementType(); +} No need for braces here

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 272564. cchen added a comment. Updated test for clarification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

RaviNarayanaswamy added a comment. How do you plan to support #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) Are you going to split this into 3 updates since your are using the arg fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271221. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7927 + CurStrides.push_back(CurStride); + DI++; +} Use preincrement Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8243 +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271183. cchen added a comment. Fix Int64Ty issue (The bitNum of APInt I used before is 32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) { cchen wrote: > ABataev wrote: > >

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 3 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270880. cchen added a comment. Resolve issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7831-7838 + llvm::Value *SizeV = nullptr; + if (CAT) { +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + }

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270536. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7821 + Context.getTypeSizeInChars(ElementType).getQuantity(); +} else if (VAT) { + ElementType =

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7327-7330 + bool IsNonContiguous = false, + MapNonContiguousArrayTy *const Offsets = nullptr, + MapNonContiguousArrayTy *const Counts = nullptr, + MapNonContiguousArrayTy *const

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 269961. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +/// non-contiguous list items in

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2082017 , @ABataev wrote: > Do you have a test for mapping of something like `arr[0][:n]`, where the base > is an array subscript and the remaining part is an array section? I'm not having it right now, but it seems

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 269663. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Do you have a test for mapping of something like `arr[0][:n]`, where the base is an array subscript and the remaining part is an array section? Comment at: clang/include/clang/AST/OpenMPClause.h:4680-4681 +:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069435 , @ABataev wrote: > In D79972#2069366 , @cchen wrote: > > > In D79972#2069358 , @ABataev wrote: > > > > > In D79972#2069322

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 268009. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2069366 , @cchen wrote: > In D79972#2069358 , @ABataev wrote: > > > In D79972#2069322 , @cchen wrote: > > > > > In D79972#2068976

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069358 , @ABataev wrote: > In D79972#2069322 , @cchen wrote: > > > In D79972#2068976 , @ABataev wrote: > > > > > Still: Did you think about

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2069322 , @cchen wrote: > In D79972#2068976 , @ABataev wrote: > > > Still: Did you think about implementing it in the compiler instead of the > > runtime? > > > I'm not sure I

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2068976 , @ABataev wrote: > Still: Did you think about implementing it in the compiler instead of the > runtime? I'm not sure I understand your question, which part of code are you asking? The main work compiler needs

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Still: Did you think about implementing it in the compiler instead of the runtime? Comment at: clang/include/clang/AST/OpenMPClause.h:4676-4677 explicit MappableComponent() = default; -explicit MappableComponent(Expr *AssociatedExpression, +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 267725. cchen added a comment. - Use PointerIntPair to pass non-contiguous information in AST - Error out in Sema if we don't have enough size information for cases involving pointers - Allows `*arr[N][M]` since we don't need size information for the last

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16537 AllowWholeSizeArraySection = false; +} else if (DKind == OMPD_target_update && + SemaRef.getLangOpts().OpenMP >= 50) { cchen wrote: > ABataev wrote: > >

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400 + if (OASE || OAShE || + dyn_cast(I->getAssociatedExpression())) { +DimSize++; + } ABataev wrote: > Do you

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 266921. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Did you think about implementing it in the compiler instead of the runtime? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400 + if (OASE || OAShE || + dyn_cast(I->getAssociatedExpression())) { +DimSize++; + }

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16537 AllowWholeSizeArraySection = false; +} else if (DKind == OMPD_target_update && + SemaRef.getLangOpts().OpenMP >= 50) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2058608 , @ABataev wrote: > In D79972#2058555 , @cchen wrote: > > > In D79972#2058516 , @ABataev wrote: > > > > > Is my guess correct that

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2058555 , @cchen wrote: > In D79972#2058516 , @ABataev wrote: > > > Is my guess correct that for OpenMP >= 50 for target update directive we > > always emit `possibly

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2058516 , @ABataev wrote: > Is my guess correct that for OpenMP >= 50 for target update directive we > always emit `possibly non-continuous` runtime calls? My intent is to emit `possibly non-contiguous` runtime calls

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5315 + private llvm::TrailingObjects< + OMPMapClause, Expr *, ValueDecl *, bool, unsigned, +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Is my guess correct that for OpenMP >= 50 for target update directive we always emit `possibly non-continuous` runtime calls? Comment at: clang/include/clang/AST/OpenMPClause.h:5315 + private llvm::TrailingObjects< + OMPMapClause, Expr

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2049838 , @ABataev wrote: > How are you going to pass this non-contiguous data in the runtime? Are you > going to map it in a loop or convert this non-contiguous data into the > contiguous and map it as a contiguous

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. How are you going to pass this non-contiguous data in the runtime? Are you going to map it in a loop or convert this non-contiguous data into the contiguous and map it as a contiguous chunk of data? Your presentation provides interface only interface changes but has

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 265562. cchen added a comment. Herald added a subscriber: sstefan1. Remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 264266. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClause.cpp

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. In order not to modify the `tgt_target_data_update` information but still be able to pass the extra information