[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGab4d02cf2659: [clang] [MinGW] Fix libunwind extension (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 added a comment. No worries. Mateusz Mikuła CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM now - thanks! What's your preferred git author line for this project? I can probably push it tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 267036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/compiler-rt-unwind.c Index: clang/test/Driver/compiler-rt-unwind.c

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 267034. mati865 added a comment. Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/compiler-rt-unwind.c Index:

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo added a comment. In D79995#2054298 , @mati865 wrote: > @mstorsjo @rnk will be away since June Yeah, I've noticed - but was waiting to see if he'd comment on it before that. Btw, would it be possible to add some test for this? (Sorry for not

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 added a comment. @mstorsjo @rnk will away since June CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 264292. mati865 added a comment. Applied review comment and formatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index:

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo added a reviewer: rnk. mstorsjo added a subscriber: rnk. mstorsjo added a comment. So, using `-l:libunwind.dll.a` is definitely more correct than `-l:libunwind.so` on this platform, so in that sense this is good. In my toolchains I don't use this option at all so far, because I have