[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

2020-05-19 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG48aa781ae44a: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines (authored by sammccall). Changed prior to commit:

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

2020-05-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/Tooling/fixed-database.cpp:6 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/" +// RUN: echo '# this is a comment' >> %t/compile_flags.txt // -I flag is relative to %t (where

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

2020-05-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for remembering this :D Comment at: clang/test/Tooling/fixed-database.cpp:6 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/" +// RUN: echo '# this is a

[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

2020-05-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. These files tend to be hand-authored, and people get very confused. I can't think of any reason that such whitespace would be intended. Repository: rG