[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

2020-05-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. In D80172#2042946 , @rnk wrote: > I'd be fine going back to the behavior from before. > > > Without this behavior there is no intrinsic for 32 bit rotates on these > > platforms. > > Strictly speaking, there seems to be

[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

2020-05-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I'd be fine going back to the behavior from before. > Without this behavior there is no intrinsic for 32 bit rotates on these > platforms. Strictly speaking, there seems to be `__builtin_rotate(left|right)32`, which is portable to all clang platforms. Repository: rG

[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

2020-05-18 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese created this revision. Bigcheese added reviewers: bruno, rnk, erichkeane. Bigcheese added a project: clang. Herald added a subscriber: dexonsmith. This reverts commit 92146ce399cdb26c3a9aa4d68af8cacb7c1c0fef. This commit broke users targeting LP64 systems that expect these intrinsics