[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay added a comment. I think we should take these tests now once they are landed, and we can begin to flesh them out with for() , do(), while() if() conditions so we always know we are not breaking the default style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay updated this revision to Diff 265331. MyDeveloperDay added a comment. Adding WebKitStyle() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214 Files: clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD added a comment. Just belatedly caught something: Webkit style is supported too but not listed here. Can you add that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MarcusJohnson91 accepted this revision. MarcusJohnson91 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD added a comment. +1 for this idea. It'd eventually be neat to also take all samples from the style guide of each project and test them, if there aren't licensing concerns. LGTM with an appropriate merge fix/CI passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: MarcusJohnson91, krasimir, JakeMerdichAMD. MyDeveloperDay added projects: clang, clang-format. This revision is to complement D75791: [clang-format] Added new option IndentExternBlock so we