[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-22 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1b02db52b79e: [X86] Update some av512 shift intrinsics to use unsigned int parameter… (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-22 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 265787. craig.topper added a comment. Add -Wsign-conversion. Fix two test issues that exposed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251 Files: clang/lib/Headers/avx512bwintrin.h

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-22 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. In D80251#2049975 , @craig.topper wrote: > In D80251#2049418 , @RKSimon wrote: > > > Can we add

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D80251#2049418 , @RKSimon wrote: > Can we add -Wsign-conversion checks to the tests? That was mentioned on > PR45931 I can. Will that do anything other than show that my test_* functions were updated to match the new

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-21 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Can we add -Wsign-conversion checks to the tests? That was mentioned on PR45931 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251 ___ cfe-commits mailing list

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D80251#2046564 , @spatel wrote: > Is it possible to fix those other 5 in the Intel docs for consistency, or is > there some functional reason that those are different? I think it was just a mistake. The docs are derived

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-20 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. Is it possible to fix those other 5 in the Intel docs for consistency, or is there some functional reason that those are different? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. There are 65 that take a scalar shift amount. Intel documentation shows 60 of them taking unsigned int. There are 5 versions of srli_epi16 that use int, the 512-bit maskz and 128/256 mask/maskz. Fixes PR45931