RE: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

Wu Subject: Re: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag thanks for letting me know. it is annoying that the test is flaky, but I don't see that flakiness on any other buildbot I've access to. Is there any chance that you are running in a custom build

Re: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

thanks for letting me know. it is annoying that the test is flaky, but I don't see that flakiness on any other buildbot I've access to. Is there any chance that you are running in a custom build configuration that I can try to repro the failure? Also what's the falkiness ratio? On Tue, Jun 2,

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

wolfgangp added a comment. Hi! Shortly after this patch went in, we started to see intermittent failures with the unittest TUSchedulerTests.ManyUpdates. The build server (Windows) we're running it on is quite powerful and our own hand-run tests only take about 400 ms, so we don't really

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f4ba66ecc87: [clangd] Run PreambleThread in async mode behind a flag (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 267157. kadircet marked 3 inline comments as done. kadircet added a comment. - Add comment explaining why we block on ASTWorker::update rather than consumers of a preamble Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 267156. kadircet added a comment. - Move notification from PreambleThread to ASTWorker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/ https://reviews.llvm.org/D80293 Files:

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:724 std::move(Req.WantDiags)); +// Set it after notifying ASTPeer about the

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 266814. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/ https://reviews.llvm.org/D80293 Files:

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet marked 22 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:724 std::move(Req.WantDiags)); +// Set it after notifying ASTPeer about the preamble to prevent any races. +

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1138 + if (!wait(Lock, RequestsCV, Timeout, +[&] { return Requests.empty() && !CurrentRequest; })) +return false; I'd consider pulling out an IsIdle lambda

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall added a comment. Sorry about the delay on this, I said I'd prioritize it... had a slightly odd day. Haven't reviewed the unit test yet (mostly a reminder to myself). Generally looks good... Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// Whether

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 266201. kadircet edited the summary of this revision. kadircet added a comment. - Rebase and update comments on block until idle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:248 + ReqCV.wait(Lock, [this] { +return !NextReq || NextReq->WantDiags != WantDiagnostics::Yes; + }); This is mostly

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Depends on D80198 . Repository: rG LLVM Github Monorepo