DmitryPolukhin added a comment.
@aaron.ballman - thank you for the review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80301/new/
https://reviews.llvm.org/D80301
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e7fddbd36f5: [yaml][clang-tidy] Fix multiline YAML
serialization (authored by DmitryPolukhin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80301/new/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, this seems like a pretty clean solution. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80301/new/
DmitryPolukhin added a comment.
@njames93 and @aaron.ballman - please take a look to this diff. Multiline
replacements in YAML are broken and cannot be applied correctly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80301/new/
DmitryPolukhin updated this revision to Diff 272996.
DmitryPolukhin added a comment.
Fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80301/new/
https://reviews.llvm.org/D80301
Files:
clang/include/clang/Tooling/ReplacementsYaml.h
DmitryPolukhin updated this revision to Diff 272952.
DmitryPolukhin added a comment.
Use double quotation for multiline strings. It solves problems with internal
newlines because now they are escaped. Also double quotation solves the problem
with leading whitespace after newline. In case of
