[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl reopened this revision. yaxunl added a comment. This revision is now accepted and ready to land. reopen for fixing the regression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 _

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. In D80450#2088129 , @tra wrote: > In D80450#2087938 , @tra wrote: > >> Reproducer for the regression. >> https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 >> It's not particul

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. In D80450#2087938 , @tra wrote: > Reproducer for the regression. > https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 > It's not particularly small, but that's as far as I could get it reduced. > > With the patch, an at

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. Reproducer for the regression. https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 It's not particularly small, but that's as far as I could get it reduced. With the patch, an attempt to instantiate `ag` on line 36 (in the reproducer sources I linked to above)

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rG263390d4f5f2: [CUDA][HIP] Fix implicit HD function resolution (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D80450?vs=266366&id=268590#toc Repos

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Combined with D79526 it appears to work for tensorflow build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D804

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. In D80450#2071696 , @tra wrote: > In D80450#2055463 , @tra wrote: > > > Is this patch supposed to be used with D79526 > > or instead of it? > > > ^^^ I don'

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. In D80450#2055463 , @tra wrote: > Is this patch supposed to be used with D79526 > or instead of it? ^^^ I don't think this has been answered. I would like to test this change before it lands. CHA

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl updated this revision to Diff 266366. yaxunl added a comment. Fix test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCUDA/function-overload.cu Index: clang/test/SemaCUDA/funct

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. Is this patch supposed to be used with D79526 or instead of it? Comment at: clang/test/SemaCUDA/function-overload.cu:551 + struct a { +__attribute__((device)) a(short); +__attribute__((device)) operator unsigned()

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl created this revision. yaxunl added a reviewer: tra. When implicit HD function calls a function in device compilation, if one candidate is an implicit HD function, current solution rule is: D wins over HD and H HD and H are equal this caused regression when there is an otherwise worse D c