[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-11-27 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. This patch caused severe regression in Clang 11. https://bugs.llvm.org/show_bug.cgi?id=48177 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80743/new/ https://reviews.llvm.org/D80743

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-12 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG82a21229da36: (PR46111) Properly handle elaborated types in an implicit deduction guide (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1967 +TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc()); +TypeSourceInfo *TSI =

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:1967 +TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc()); +TypeSourceInfo *TSI =

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-10 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Ping @rsmith I've done as you suggested, though I'm not sure its necessary for you to do a thorough review since you approve of the approach. Would it be alright for someone like @rjmccall or others to do the final pedantic checks? CHANGES SINCE LAST ACTION

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added a comment. In D80743#2074537 , @rsmith wrote: > In D80743#2074121 , @erichkeane > wrote: > > > @rsmith I think this implements what you've suggested? >

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 268822. erichkeane retitled this revision from "(PR46111) Desugar Elaborated types in Deduction Guides." to "(PR46111) Properly handle elaborated types in an implicit deduction guide". erichkeane edited the summary of this revision. CHANGES SINCE LAST