This revision was automatically updated to reflect the committed changes.
Closed by commit rG232d348c6eff: [MTE] Convert StackSafety into analysis
(authored by vitalybuka).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80771/new/
vitalybuka updated this revision to Diff 267802.
vitalybuka added a comment.
remove unneeded pass
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80771/new/
https://reviews.llvm.org/D80771
Files:
clang/lib/CodeGen/BackendUtil.cpp
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80771/new/
https://reviews.llvm.org/D80771
vitalybuka updated this revision to Diff 267731.
vitalybuka marked an inline comment as done.
vitalybuka added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80771/new/
https://reviews.llvm.org/D80771
Files:
vitalybuka updated this revision to Diff 267710.
vitalybuka marked an inline comment as done.
vitalybuka added a comment.
SmallPtrSet
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80771/new/
https://reviews.llvm.org/D80771
Files:
vitalybuka marked 2 inline comments as done.
vitalybuka added inline comments.
Comment at: clang/test/Driver/memtag_lto.c:126
+ // XUNSAFE: [4]: full-set
+ // XSAFE: [4]: [0,4)
int x;
eugenis wrote:
> vitalybuka wrote:
> > eugenis wrote:
> > > Alloca order
eugenis added inline comments.
Comment at: clang/test/Driver/memtag_lto.c:126
+ // XUNSAFE: [4]: full-set
+ // XSAFE: [4]: [0,4)
int x;
vitalybuka wrote:
> eugenis wrote:
> > Alloca order can easily change in the future. Not sure how to make this
> >
vitalybuka marked an inline comment as done.
vitalybuka added inline comments.
Comment at: clang/test/Driver/memtag_lto.c:126
+ // XUNSAFE: [4]: full-set
+ // XSAFE: [4]: [0,4)
int x;
eugenis wrote:
> Alloca order can easily change in the future. Not sure
vitalybuka updated this revision to Diff 267384.
vitalybuka marked 3 inline comments as done.
vitalybuka retitled this revision from "[MTE] Convert StackSafety into analysis
This lets us to remove !stack-safe metadata and
better controll when to perform StackSafety
analysis." to "[MTE] Convert
