[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rG595212569157: clang-tidy and clang-query wont crash with invalid command line options (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267505. njames93 added a comment. Actually fix the windows builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files:

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 added a comment. In D80879#2065364 , @thakis wrote: > Test fix looks good as far as I can tell. Landing and seeing what the bot > says is ok. It's fine for some of the bots to be red for a short while as > long as it isn't hours. Thanks! I'm

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

thakis accepted this revision. thakis added a comment. Test fix looks good as far as I can tell. Landing and seeing what the bot says is ok. It's fine for some of the bots to be red for a short while as long as it isn't hours. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 reopened this revision. njames93 added a comment. This revision is now accepted and ready to land. In D80879#2065350 , @thakis wrote: > This breaks check-clang-tools on windows: > http://45.33.8.238/win/16485/step_8.txt > > Looks like you need

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267504. njames93 added a comment. Hopefully fix windows test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files:

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

thakis added a comment. This breaks check-clang-tools on windows: http://45.33.8.238/win/16485/step_8.txt Looks like you need to optionally allow a .exe suffix in the test. Please take a look, and revert if it takes a while until you can fix. (I'm on a phone, else I'd fix myself.)

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267501. njames93 added a comment. Added test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files: clang-tools-extra/clang-query/tool/ClangQuery.cpp

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGf23ddbe3c3ae: clang-tidy and clang-query wont crash with invalid command line options (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but can you add test coverage for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267483. njames93 added a comment. Fix compile error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files: clang-tools-extra/clang-query/tool/ClangQuery.cpp

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivated by clang-tidy crashed for unknown command line argument. Repository: rG LLVM Github