[PATCH] D80979: [clang] Implement VectorType logic not operator.

thakis added a comment. Reverted in abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___

[PATCH] D80979: [clang] Implement VectorType logic not operator.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/17077/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___

[PATCH] D80979: [clang] Implement VectorType logic not operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0de3335edcf: [clang] Implement VectorType logic not operator. (authored by junparser). Changed prior to commit: https://reviews.llvm.org/D80979?vs=268649&id=269084#toc Repository: rG LLVM Github Mon

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268649. junparser added a comment. address the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/Sema

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:2 +// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s + +typedef __attribute__((__vector_size__(16))) float float4; erichkeane wrote: > I do

[PATCH] D80979: [clang] Implement VectorType logic not operator.

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { erichkeane wrote: > junparser wrote: > > erichke

[PATCH] D80979: [clang] Implement VectorType logic not operator.

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { junparser wrote: > erichkeane wrote: > > Why lim

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:183 +// CHECK: @_Z5test7Dv4_j +int4 test7(uint4 V0) { + // CHECK: [[CMP0:%.*]] = icmp eq <4 x i32> [[V0:%.*]], zeroinitializer logic operatio

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268366. junparser added a comment. address the comment. hi @erichkeane, most of the function in vector-1.cpp are copied from ext-vector.c with vector type changed to gcc vector type, they should emit same ir. I add test7 and test8 which test logic opera

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser added a comment. This patch implement the logic not operation of vector type. it keeps same behavior as gcc does (only allows in C++). I'll update the wrong testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://revi

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 3 inline comments as done. junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { erich

[PATCH] D80979: [clang] Implement VectorType logic not operator.

erichkeane added a comment. Write some codegen tests please, I'd like to have a better idea of what you want ! to do here. Additionally, I'm not sure as to the limits you've placed on this patch. Please justifiy them.C Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 +

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser added a comment. @erichkeane @aaron.ballman , kindly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___ cfe-commits mailing list cfe-comm

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser created this revision. junparser added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. As title. This patch implement unary operator ! of vector type. TestPlan: check-clang Repository: rG LLVM Github Monorepo ht