pdhaliwal abandoned this revision.
pdhaliwal marked an inline comment as done.
pdhaliwal added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389
- for (Arg *A : Args) {
-DAL->append(A);
+ if (DeviceOffloadKind != Action::OFK_OpenMP) {
+for (Arg *A
sameerds added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389
- for (Arg *A : Args) {
-DAL->append(A);
+ if (DeviceOffloadKind != Action::OFK_OpenMP) {
+for (Arg *A : Args) {
pdhaliwal wrote:
> arsenm wrote:
> > Needs a comment?
pdhaliwal added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389
- for (Arg *A : Args) {
-DAL->append(A);
+ if (DeviceOffloadKind != Action::OFK_OpenMP) {
+for (Arg *A : Args) {
arsenm wrote:
> Needs a comment? I don't understand
arsenm added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389
- for (Arg *A : Args) {
-DAL->append(A);
+ if (DeviceOffloadKind != Action::OFK_OpenMP) {
+for (Arg *A : Args) {
Needs a comment? I don't understand why openmp is any
pdhaliwal updated this revision to Diff 267870.
pdhaliwal added a comment.
Added lit test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80996/new/
https://reviews.llvm.org/D80996
Files:
clang/lib/Driver/ToolChains/HIP.cpp
yaxunl added a comment.
Can we have a lit test? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80996/new/
https://reviews.llvm.org/D80996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pdhaliwal created this revision.
pdhaliwal added reviewers: yaxunl, msearles, sameerds.
Herald added subscribers: cfe-commits, sstefan1, guansong, t-tye, tpr,
dstuttard, wdng, kzhuravl.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
When offloading kind is OFK_OpenMP, the
