riccibruno added a comment.
Friendly ping on this patch: this is the last change to `SequenceChecker` I had
in mind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81003/new/
https://reviews.llvm.org/D81003
riccibruno updated this revision to Diff 281999.
riccibruno edited the summary of this revision.
riccibruno added a comment.
Rebased with a few clang-format fixes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81003/new/
https://reviews.llvm.org/D8
riccibruno added a comment.
Friendly ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81003/new/
https://reviews.llvm.org/D81003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
riccibruno added a comment.
@rsmith I have modified this patch to address your comment above (we should
track where default argument(s) and/or default member initializer(s) were
used). You accepted this originally but I would like to make sure that you are
happy with the updated patch.
I was a
riccibruno added a comment.
@rsmith
> I think it's important that we handle this in the near future (though I don't
> mind if you'd like to submit this patch as-is and deal with this as a
> follow-on). For a case like:
>
> void f(int, int = a++);
>// ... some time later ...
>f(a);
>
riccibruno updated this revision to Diff 271659.
riccibruno added a comment.
- Remove a left-over FIXME in the tests.
- Use a `%select` in the diagnostic.
- Pack `AdditionalSourceLocationData` into two `unsigned`s.
- Simplify the chain walking code in `checkUsage`.
- Mark the patch as needing revi
riccibruno updated this revision to Diff 271480.
riccibruno added a comment.
Remove the FIXME comment in the `default_init` test. The behavior is actually
fine since `struct S { int b = ++a; };` is not an aggregate in C++11 but is an
aggregate in C++17.
Repository:
rG LLVM Github Monorepo
C
riccibruno marked an inline comment as done.
riccibruno added inline comments.
Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:313
+//
+// However SequenceChecker::VisitCXXConstructExpr only visit the arguments
+// of the CXXConstructExpr and is not visiting the a
riccibruno marked an inline comment as done.
riccibruno added inline comments.
Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:313
+//
+// However SequenceChecker::VisitCXXConstructExpr only visit the arguments
+// of the CXXConstructExpr and is not visiting the a
riccibruno updated this revision to Diff 271464.
riccibruno retitled this revision from "[clang] SequenceChecker: Also visit
default arguments." to "[clang] SequenceChecker: Also visit default arguments
and default initializers.".
riccibruno edited the summary of this revision.
riccibruno added a
riccibruno marked 3 inline comments as done.
riccibruno added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2126
+ "in default initializer used here">;
def select_initialized_entity_kind : TextSubstitution<
I should just use `%
11 matches
Mail list logo
