[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-07-01 Thread Saiyedul Islam via Phabricator via cfe-commits 
saiislam added a comment.

In D81098#2123559 , @clementval wrote:

> In D81098#2112159 , @ABataev wrote:
>
> > LG
>
>
> Since this revision landed two tests are failing.
>
> ` libomp.env::kmp_set_dispatch_buf.c` and 
> `libomp.worksharing/for::kmp_set_dispatch_buf.c`. It was also reported on the 
> mailing list 
> (http://lists.llvm.org/pipermail/openmp-dev/2020-June/003507.html). Any idea 
> how we can fix this quickly? @jdoerfert
>
>   OR maybe this is known and will be taken care later?


Thank you @clementval. I have posted a review to temporarily disable these 
tests for 5.0 (they are passing with 4.5): https://reviews.llvm.org/D82963


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-30 Thread Valentin Clement via Phabricator via cfe-commits 
clementval added a comment.

In D81098#2112159 , @ABataev wrote:

> LG


Since this revision landed two tests are failing.

` libomp.env::kmp_set_dispatch_buf.c` and 
`libomp.worksharing/for::kmp_set_dispatch_buf.c`. It was also reported on the 
mailing list 
(http://lists.llvm.org/pipermail/openmp-dev/2020-June/003507.html). Any idea 
how we can fix this quickly? @jdoerfert
 OR maybe this is known and will be taken care later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-24 Thread Alexey Bataev via Phabricator via cfe-commits 
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-17 Thread Alexey Bataev via Phabricator via cfe-commits 
ABataev added a comment.

Looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-10 Thread Alexey Bataev via Phabricator via cfe-commits 
ABataev added a comment.

In D81098#2085786 , @saiislam wrote:

> [Work in progress] Requesting early comments. 28 tests are still failing.


Looks good in general


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-08 Thread Alexey Bataev via Phabricator via cfe-commits 
ABataev added a comment.

Need to update few other places.
CompilerInvocation.cpp:3082 and CompilerInvocation.cpp:3085, which sets the 
default version to 45 in the presense of the target option or simd option. Most 
probably, need to remove this check. It was used to use 45 as the default 
version for target(simd)-based switches when the default version was 40.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-08 Thread Saiyedul Islam via Phabricator via cfe-commits 
saiislam updated this revision to Diff 269239.
saiislam added a comment.

Fixed 25 out of 75 failing test cases by marking all old default cases as omp4 
tests, and new tests as omp5.
All these tests are now specific to the version of openmp, so that we don't run 
into similar problem during next version upgrade.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098

Files:
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/Frontend/InitPreprocessor.cpp
  clang/test/OpenMP/declare_target_messages.cpp
  clang/test/OpenMP/distribute_parallel_for_simd_loop_messages.cpp
  clang/test/OpenMP/distribute_simd_loop_messages.cpp
  clang/test/OpenMP/driver.c
  clang/test/OpenMP/for_collapse_messages.cpp
  clang/test/OpenMP/for_loop_messages.cpp
  clang/test/OpenMP/for_simd_loop_messages.cpp
  clang/test/OpenMP/master_taskloop_loop_messages.cpp
  clang/test/OpenMP/master_taskloop_simd_loop_messages.cpp
  clang/test/OpenMP/nesting_of_regions.cpp
  clang/test/OpenMP/parallel_for_loop_messages.cpp
  clang/test/OpenMP/parallel_for_simd_codegen.cpp
  clang/test/OpenMP/parallel_for_simd_loop_messages.cpp
  clang/test/OpenMP/parallel_master_taskloop_loop_messages.cpp
  clang/test/OpenMP/parallel_master_taskloop_simd_loop_messages.cpp
  clang/test/OpenMP/simd_loop_messages.cpp
  clang/test/OpenMP/target_depend_messages.cpp
  clang/test/OpenMP/target_enter_data_depend_messages.cpp
  clang/test/OpenMP/target_exit_data_depend_messages.cpp
  clang/test/OpenMP/taskloop_loop_messages.cpp
  clang/test/OpenMP/taskloop_simd_loop_messages.cpp
  clang/test/OpenMP/teams_distribute_loop_messages.cpp
  clang/test/OpenMP/teams_distribute_parallel_for_loop_messages.cpp
  clang/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
  clang/test/OpenMP/teams_distribute_simd_loop_messages.cpp

Index: clang/test/OpenMP/teams_distribute_simd_loop_messages.cpp
===
--- clang/test/OpenMP/teams_distribute_simd_loop_messages.cpp
+++ clang/test/OpenMP/teams_distribute_simd_loop_messages.cpp
@@ -1,7 +1,7 @@
-// RUN: %clang_cc1 -fsyntax-only -fopenmp -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
+// RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=45 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
 // RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=50 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp5 %s -Wuninitialized
 
-// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
+// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -fopenmp-version=45 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
 // RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -fopenmp-version=50 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp5 %s -Wuninitialized
 
 class S {
Index: clang/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
===
--- clang/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
+++ clang/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
@@ -1,7 +1,7 @@
-// RUN: %clang_cc1 -fsyntax-only -fopenmp -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
+// RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=45 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
 // RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=50 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp5 %s -Wuninitialized
 
-// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
+// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -fopenmp-version=45 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
 // RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -fopenmp-version=50 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp5 %s -Wuninitialized
 
 class S {
Index: clang/test/OpenMP/teams_distribute_parallel_for_loop_messages.cpp
===
--- clang/test/OpenMP/teams_distribute_parallel_for_loop_messages.cpp
+++ clang/test/OpenMP/teams_distribute_parallel_for_loop_messages.cpp
@@ -1,7 +1,7 @@
-// RUN: %clang_cc1 -fsyntax-only -fopenmp -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
+// RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=45 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp4 %s -Wuninitialized
 // RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=50 -x c++ -std=c++11 -fexceptions -fcxx-exceptions -verify=expected,omp5 %s

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-03 Thread Saiyedul Islam via Phabricator via cfe-commits 
saiislam added a comment.

Currently, following 75 lit-tests are failing.

1. Clang :: OpenMP/declare_reduction_codegen.c
2. Clang :: OpenMP/declare_reduction_codegen.cpp
3. Clang :: OpenMP/declare_target_messages.cpp
4. Clang :: OpenMP/declare_variant_implementation_vendor_codegen.cpp
5. Clang :: OpenMP/distribute_parallel_for_simd_loop_messages.cpp
6. Clang :: OpenMP/distribute_simd_loop_messages.cpp
7. Clang :: OpenMP/driver.c
8. Clang :: OpenMP/for_codegen.cpp
9. Clang :: OpenMP/for_collapse_messages.cpp
10. Clang :: OpenMP/for_loop_messages.cpp
11. Clang :: OpenMP/for_simd_loop_messages.cpp
12. Clang :: OpenMP/master_taskloop_loop_messages.cpp
13. Clang :: OpenMP/master_taskloop_simd_loop_messages.cpp
14. Clang :: OpenMP/nesting_of_regions.cpp
15. Clang :: OpenMP/ordered_codegen.cpp
16. Clang :: OpenMP/parallel_for_codegen.cpp
17. Clang :: OpenMP/parallel_for_loop_messages.cpp
18. Clang :: OpenMP/parallel_for_simd_codegen.cpp
19. Clang :: OpenMP/parallel_for_simd_loop_messages.cpp
20. Clang :: OpenMP/parallel_master_taskloop_loop_messages.cpp
21. Clang :: OpenMP/parallel_master_taskloop_simd_loop_messages.cpp
22. Clang :: OpenMP/simd_loop_messages.cpp
23. Clang :: OpenMP/single_codegen.cpp
24. Clang :: OpenMP/target_depend_messages.cpp
25. Clang :: OpenMP/target_enter_data_depend_messages.cpp
26. Clang :: OpenMP/target_exit_data_depend_messages.cpp
27. Clang :: OpenMP/target_map_messages.cpp
28. Clang :: OpenMP/target_messages.cpp
29. Clang :: OpenMP/target_parallel_depend_messages.cpp
30. Clang :: OpenMP/target_parallel_for_depend_messages.cpp
31. Clang :: OpenMP/target_parallel_for_loop_messages.cpp
32. Clang :: OpenMP/target_parallel_for_map_messages.cpp
33. Clang :: OpenMP/target_parallel_for_simd_depend_messages.cpp
34. Clang :: OpenMP/target_parallel_for_simd_is_device_ptr_messages.cpp
35. Clang :: OpenMP/target_parallel_for_simd_map_messages.cpp
36. Clang :: OpenMP/target_parallel_is_device_ptr_messages.cpp
37. Clang :: OpenMP/target_parallel_map_messages.cpp
38. Clang :: OpenMP/target_simd_depend_messages.cpp
39. Clang :: OpenMP/target_simd_map_messages.cpp
40. Clang :: OpenMP/target_teams_depend_messages.cpp
41. Clang :: OpenMP/target_teams_distribute_depend_messages.cpp
42. Clang :: OpenMP/target_teams_distribute_loop_messages.cpp
43. Clang :: OpenMP/target_teams_distribute_map_messages.cpp
44. Clang :: OpenMP/target_teams_distribute_parallel_for_depend_messages.cpp
45. Clang :: 
OpenMP/target_teams_distribute_parallel_for_is_device_ptr_messages.cpp
46. Clang :: 
OpenMP/target_teams_distribute_parallel_for_lastprivate_messages.cpp
47. Clang :: OpenMP/target_teams_distribute_parallel_for_loop_messages.cpp
48. Clang :: OpenMP/target_teams_distribute_parallel_for_map_messages.cpp
49. Clang :: 
OpenMP/target_teams_distribute_parallel_for_simd_depend_messages.cpp
50. Clang :: 
OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_messages.cpp
51. Clang :: 
OpenMP/target_teams_distribute_parallel_for_simd_is_device_ptr_messages.cpp
52. Clang :: 
OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_messages.cpp
53. Clang :: OpenMP/target_teams_distribute_parallel_for_simd_map_messages.cpp
54. Clang :: OpenMP/target_teams_distribute_simd_depend_messages.cpp
55. Clang :: OpenMP/target_teams_distribute_simd_firstprivate_messages.cpp
56. Clang :: OpenMP/target_teams_distribute_simd_is_device_ptr_messages.cpp
57. Clang :: OpenMP/target_teams_distribute_simd_lastprivate_messages.cpp
58. Clang :: OpenMP/target_teams_distribute_simd_loop_messages.cpp
59. Clang :: OpenMP/target_teams_distribute_simd_map_messages.cpp
60. Clang :: OpenMP/target_teams_distribute_simd_private_messages.cpp
61. Clang :: OpenMP/target_teams_is_device_ptr_messages.cpp
62. Clang :: OpenMP/target_teams_map_messages.cpp
63. Clang :: OpenMP/target_update_depend_messages.cpp
64. Clang :: OpenMP/target_update_from_messages.cpp
65. Clang :: OpenMP/target_update_to_messages.cpp
66. Clang :: OpenMP/taskloop_loop_messages.cpp
67. Clang :: OpenMP/taskloop_simd_loop_messages.cpp
68. Clang :: OpenMP/teams_distribute_loop_messages.cpp
69. Clang :: OpenMP/teams_distribute_parallel_for_loop_messages.cpp
70. Clang :: OpenMP/teams_distribute_parallel_for_simd_firstprivate_messages.cpp
71. Clang :: OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
72. Clang :: OpenMP/teams_distribute_simd_firstprivate_messages.cpp
73. Clang :: OpenMP/teams_distribute_simd_loop_messages.cpp
74. Clang :: OpenMP/teams_messages.cpp
75. Clang :: OpenMP/threadprivate_codegen.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81098/new/

https://reviews.llvm.org/D81098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-03 Thread Saiyedul Islam via Phabricator via cfe-commits 
saiislam created this revision.
saiislam added reviewers: gregrodgers, jdoerfert.
Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl.
Herald added a project: clang.

When -fopenmp option is specified then version 5.0 will be set as
default.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81098

Files:
  clang/lib/Frontend/CompilerInvocation.cpp


Index: clang/lib/Frontend/CompilerInvocation.cpp
===
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -3060,8 +3060,8 @@
 }
   }
 
-  // Check if -fopenmp is specified and set default version to 4.5.
-  Opts.OpenMP = Args.hasArg(options::OPT_fopenmp) ? 45 : 0;
+  // Check if -fopenmp is specified and set default version to 5.0.
+  Opts.OpenMP = Args.hasArg(options::OPT_fopenmp) ? 50 : 0;
   // Check if -fopenmp-simd is specified.
   bool IsSimdSpecified =
   Args.hasFlag(options::OPT_fopenmp_simd, options::OPT_fno_openmp_simd,


Index: clang/lib/Frontend/CompilerInvocation.cpp
===
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -3060,8 +3060,8 @@
 }
   }
 
-  // Check if -fopenmp is specified and set default version to 4.5.
-  Opts.OpenMP = Args.hasArg(options::OPT_fopenmp) ? 45 : 0;
+  // Check if -fopenmp is specified and set default version to 5.0.
+  Opts.OpenMP = Args.hasArg(options::OPT_fopenmp) ? 50 : 0;
   // Check if -fopenmp-simd is specified.
   bool IsSimdSpecified =
   Args.hasFlag(options::OPT_fopenmp_simd, options::OPT_fno_openmp_simd,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits