[PATCH] D81176: [HIP] Add default header and include path

zhuhan0 added a comment. In D81176#2106382 , @yaxunl wrote: > In D81176#2105944 , @zhuhan0 wrote: > > > This broke a test `clang/test/Tooling/clang-check-offload.cpp` for a > > critical Linux distro at Facebook.

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2105944 , @zhuhan0 wrote: > This broke a test `clang/test/Tooling/clang-check-offload.cpp` for a critical > Linux distro at Facebook. With this change, the test adds a `-include > __clang_hip_runtime_wrapper` argument.

[PATCH] D81176: [HIP] Add default header and include path

zhuhan0 added a comment. This broke a test `clang/test/Tooling/clang-check-offload.cpp` for a critical Linux distro at Facebook. With this change, the test adds a `-include __clang_hip_runtime_wrapper` argument. The wrapper includes some standard c++ headers, but our distro don't have those

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077940 , @thakis wrote: > One more example failure: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16333 > > (Note I had re-reverted your reland, see the 2 comments above your comment.) Sorry I

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. One more example failure: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16333 (Note I had re-reverted your reland, see the 2 comments above your comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077333 , @yaxunl wrote: > In D81176#2077319 , @thakis wrote: > > > Still broken: http://45.33.8.238/win/16976/summary.html > > > reverted. > > The difficulty for fixing these

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Even fails on some linux bots: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/49595/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ahip-host-cpu-macros.cu Re-reverted in 2920348063221a0603ee96909536bc480f43a7ac

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. The recommit again broke tests on mac and windows: http://45.33.8.238/win/17004/step_7.txt http://45.33.8.238/mac/15014/step_7.txt This is like the 8th distinct build break today (most not yours, of course). Let's revert and call it a weekend, and try again next week.

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077319 , @thakis wrote: > Still broken: http://45.33.8.238/win/16976/summary.html reverted. The difficulty for fixing these failures is that they only show up on some systems I do not have access and cannot see the

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Still broken: http://45.33.8.238/win/16976/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits mailing list

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077254 , @thakis wrote: > Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt I will try to fix it one more time. If it still fails I will revert it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. This is still failing on Windows: http://45.33.8.238/win/16970/step_7.txt Please take a look and revert for now if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/

[PATCH] D81176: [HIP] Add default header and include path

This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rG11d06b9511bd: [HIP] Add default header and include path (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D81176: [HIP] Add default header and include path

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/ROCm.h:68 + + // CUDA architectures for which we have raised an error in + // CheckRocmVersionSupportsArch. tra wrote: > CUDA -> GPU? > Looks like

[PATCH] D81176: [HIP] Add default header and include path

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you for the patch. This will make my life a lot easier. There are a few nits, but it's LGTM in general. Do I understand it correctly that for detection of HIP installation all we need is to

[PATCH] D81176: [HIP] Add default header and include path

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, mgorny, nhaehnle, jvesely. To support std::complex and some other standard C/C++ functions in HIP device code, they need to be forced to be `__host__ __device__` functions by pragmas. This is done by