[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev abandoned this revision. ABataev added a comment. In D81192#2074878 , @jdoerfert wrote: > In D81192#2074762 , @ABataev wrote: > > > In D81192#2074732 , @jdoerfert >

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

jdoerfert added a comment. In D81192#2074762 , @ABataev wrote: > In D81192#2074732 , @jdoerfert wrote: > > > I doubt this is the right fix. I'll take a closer look. > > > I believe, the issue is caused by the new

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev updated this revision to Diff 268592. ABataev added a comment. Rebase and fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev added a comment. In D81192#2074732 , @jdoerfert wrote: > I doubt this is the right fix. I'll take a closer look. I believe, the issue is caused by the new attributes for kmpc_critical/kmpc_end_critical functions. They are marked as

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

jdoerfert added a comment. I doubt this is the right fix. I'll take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 ___ cfe-commits mailing list

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

mikerice added a comment. Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'? I haven't seen any test fail for those yet though. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:357 ///should be called. +

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev added a comment. In D81192#2074677 , @mikerice wrote: > Is it possible to have the same problem with other directives, like 'omp > single' or 'omp master'? I haven't seen any test fail for those yet though. I rather doubt. The main problem

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: llvm-commits, sstefan1, jfb, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. Need to emit memory barriers upon enter/exit to/from critical region to prevent code movement.